Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced the test cases for xcf files #290

Closed
wants to merge 28 commits into from
Closed

Enhanced the test cases for xcf files #290

wants to merge 28 commits into from

Conversation

a523
Copy link
Contributor

@a523 a523 commented Dec 26, 2021

#286

PR Goal

The test case judges whether the generated image is expected by directly comparing the difference between the two image files

Implemented solution

Use this ImageHash library to do this

Checkpoints

  • If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
  • Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
    This is a test case in itself, so there is no test case for it.
  • The PR or the original issue contains a short summary of the implemented solution.

a523 and others added 28 commits October 19, 2021 20:53
@a523
modify image__wand builder so that it is like common thumbnail genera…
9a87fb5 
…tion strategies
@a523
enable wand builder and disable others
2c8c8e6
@a523
reintroduce white background for file with transparency
24463a1
@a523
test case for transparent img
1af97cc
@a523
deprecate Pillow and ImageMagick (command line) builder
7572911
@a523
support progressive JPEG
6dbd8d3
@a523
rename
15aeab2
@a523
add doc about how to enable eps format support
4720aa4
@a523
refactor wand build
8c08a72
@a523
format
bfeb419
@a523
update supported mimetypes
a4ccee1
@inkhey
fix supported mimetype table and weight
3aa7c7a
@inkhey
Merge branch 'develop' of github.com:algoo/preview-generator into wand
4e4ba63
@inkhey
reintroduce raw/xcf support
2a73bd8
@inkhey
add test for raw file without extension
5409818
@a523
support file that without extension
6198027
@a523
fix: merge layers
946e66c
@a523
make sure transparency turns white
e6091f0
@a523
fix test case of heic
32ec567
@inkhey @a523
misc: add concourse ci
33126d5 
* misc: add concourse ci
* fix: update drawio with functional install link

PR ref: algoo#279
Co-authored-by: raphj <[email protected]>
@inkhey @a523
fix(backend): enforce office mimetype and add better exception
445bf66 
- Add all office mimetypes mapping supported by LibreOffice to mimetypes_storage to avoid issue of lacking mimetype in system.
- add known issue info about mimetypes issues.
- better logs when mimetype is not found.

Issue ref: algoo#283
PR ref: algoo#284
Co-authored-by: raphj <[email protected]>
@inkhey @a523
v0.26
40a1450
@inkhey @a523
fix readme
a6b1139
@inkhey @a523
fix: Repair loading builders without pytest and make code more explic…
33962c6 
…it/safe about such issue
@a523
Merge remote-tracking branch 'algoo/develop' into wand
edcf565
@a523
Merge remote-tracking branch 'algoo/develop' into wand
2c2fdc7
@a523
Merge remote-tracking branch 'algoo/develop' into develop
95d99bf
@a523
add test case for xcf
7c310c8
@a523 a523 closed this Dec 26, 2021
@a523 a523 deleted the wand branch January 17, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a523 @inkhey